On Fri, Aug 22, 2025 at 09:54:46AM +0200, Greg KH wrote:
On Fri, Aug 22, 2025 at 03:48:46PM +0800, Herbert Xu wrote:
On Fri, Aug 22, 2025 at 08:16:36AM +0100, Giovanni Cabiddu wrote:
Wouldn't it be simpler to drop the below changes to crypto/zstd.c in this patch and avoid backporting commit f5ad93ffb541 ("crypto: zstd - convert to acomp") to stable?
f5ad93ffb541 appears to be more of a feature than a fix, and there are related follow-up changes that aren't marked with a Fixes tag:
03ba056e63d3 ("crypto: zstd - fix duplicate check warning") 25f4e1d7193d ("crypto: zstd - replace zero-length array with flexible array member")
Eric, Herbert, what's your take?
Yes there is no reason to backport that patch at all.
Both now dropped, thanks.
Thanks Greg.
I'm going to send a backport for the second patch, 962ddc5a7a4b ("crypto: acomp - Fix CFI failure due to type punning"), which includes only the required logic for deflate.
Regards,