Re: [PATCH -next] spi: Fix double IDR allocation with DT aliases

Hi Geert,

On Tue, Aug 21, 2018 at 6:53 AM, Geert Uytterhoeven geert+renesas@glider.be wrote:

If the SPI bus number is provided by a DT alias, idr_alloc() is called twice, leading to:

WARNING: CPU: 1 PID: 1 at drivers/spi/spi.c:2179 spi_register_controller+0x11c/0x5d8
couldn't get idr

Fix this by moving the handling of fixed SPI bus numbers up, before the DT handling code fills in ctlr->bus_num.

Fixes: 1a4327fbf4554d5b ("spi: fix IDR collision on systems with both fixed and dynamic SPI bus numbers") Signed-off-by: Geert Uytterhoeven geert+renesas@glider.be

This fixes SPI on imx51-babbage, thanks.

Tested-by: Fabio Estevam fabio.estevam@nxp.com