Re: [PATCH] vfs: fix EBUSY on FSCONFIG_CMD_CREATE retry

On Mon, Dec 15, 2025 at 4:46 PM Jan Kara jack@suse.cz wrote:

On Sat 13-12-25 02:03:56, Chen Linxuan via B4 Relay wrote:

...

If the syscall is restarted, fsconfig() is called again and retrieves the *same* fs_context. However, vfs_cmd_create() rejects the call because the phase was left as FS_CONTEXT_CREATING during the first attempt:

Well, not quite. The phase is actually set to FS_CONTEXT_FAILED if vfs_get_tree() returns any error. Still the effect is the same.

Oh, that's a mistake.

Thanks for the patch. It looks good to me. I'd slightly prefer style like:

    if (ret) {
            if (ret == -ERESTARTNOINTR)
                    fc->phase = FS_CONTEXT_CREATE_PARAMS;
            else
                    fc->phase = FS_CONTEXT_FAILED;
            return ret;
    }

Will be applied in v2.