Re: [PATCH] spi: spl022: fix Microwire full duplex mode

On Fri, Oct 22, 2021 at 04:21:04PM +0200, Thomas Perrot wrote:

There are missing braces in the function that verify controller parameters, then an error is always returned when the parameter to select Microwire frames operation is used on devices allowing it.

Signed-off-by: Thomas Perrot thomas.perrot@bootlin.com

drivers/spi/spi-pl022.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index feebda66f56e..e4484ace584e 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -1716,12 +1716,13 @@ static int verify_controller_parameters(struct pl022 *pl022, return -EINVAL; } } else {

• 	if (chip_info->duplex != SSP_MICROWIRE_CHANNEL_FULL_DUPLEX)
  

• 	if (chip_info->duplex != SSP_MICROWIRE_CHANNEL_FULL_DUPLEX) {
  	dev_err(&pl022->adev->dev,
  		"Microwire half duplex mode requested,"
  		" but this is only available in the"
  		" ST version of PL022\n");
  

• 	return -EINVAL;
  

• 		return -EINVAL;
  

• 	}
  

  } } return 0;

-- 2.31.1

<formletter>

This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.

</formletter>