Re: [PATCH 4.19 014/639] leds: tlc591xx: update the maximum brightness

On Fri 2020-01-24 10:23:04, Greg Kroah-Hartman wrote:

From: Jean-Jacques Hiblot jjhiblot@ti.com

commit a2cafdfd8cf5ad8adda6c0ce44a59f46431edf02 upstream.

The TLC chips actually offer 257 levels:

• 0: led OFF
• 1-255: Led dimmed is using a PWM. The duty cycle range from 0.4% to 99.6%
• 256: led fully ON

Fixes: e370d010a5fe ("leds: tlc591xx: Driver for the TI 8/16 Channel i2c LED driver") Signed-off-by: Jean-Jacques Hiblot jjhiblot@ti.com Signed-off-by: Pavel Machek pavel@ucw.cz Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org

Its a new feature, really and quite unusual one: 257 brightness levels is not usual. It is theoretically safe, but...

Lets not do that for -stable.

(I'm a LED maintainer).

Best regards, Pavel