On Thu, Jul 15, 2021 at 07:22:00PM +0800, Gao Xiang wrote:
Hi Greg,
On Thu, Jul 15, 2021 at 12:52:33PM +0200, Greg Kroah-Hartman wrote:
On Fri, Jul 09, 2021 at 09:24:08PM +0800, Gao Xiang wrote:
commit a510b616131f85215ba156ed67e5ed1c0701f80f upstream.
That is not what this commit id is :(
Please fix this up and be more careful.
That's the exact commit, the original upstream commit was named as "MIPS: Add support for ZSTD-compressed kernels", which contains the memmove() definition so the upstream / 5.10 LTS kernel is fine.
But for 5.4 LTS, we shouldn't backport the whole patch since only memmove() part is needed in order to fix the build regression...
That was not obvious, and is confusing :(
Please just submit the fix and say _why_ this is not an upstream commit, do not attempt to emulate an upstream commit like your change did.
thanks,
greg k-h