3.16.62-rc1 review patch. If anyone has any objections, please let me know.
------------------
From: Anand Jain Anand.Jain@oracle.com
commit 3c1dbdf54a31f4f049a33214c3096595988786bf upstream.
we are assigning number_devices to the total_bytes, that's very confusing for a moment
Signed-off-by: Anand Jain anand.jain@oracle.com Reviewed-by: David Sterba dsterba@suse.cz Signed-off-by: Chris Mason clm@fb.com Signed-off-by: Ben Hutchings ben@decadent.org.uk --- fs/btrfs/volumes.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
--- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -2039,7 +2039,7 @@ int btrfs_init_new_device(struct btrfs_r struct list_head *devices; struct super_block *sb = root->fs_info->sb; struct rcu_string *name; - u64 total_bytes; + u64 tmp; int seeding_dev = 0; int ret = 0;
@@ -2142,13 +2142,13 @@ int btrfs_init_new_device(struct btrfs_r if (!blk_queue_nonrot(bdev_get_queue(bdev))) root->fs_info->fs_devices->rotating = 1;
- total_bytes = btrfs_super_total_bytes(root->fs_info->super_copy); + tmp = btrfs_super_total_bytes(root->fs_info->super_copy); btrfs_set_super_total_bytes(root->fs_info->super_copy, - total_bytes + device->total_bytes); + tmp + device->total_bytes);
- total_bytes = btrfs_super_num_devices(root->fs_info->super_copy); + tmp = btrfs_super_num_devices(root->fs_info->super_copy); btrfs_set_super_num_devices(root->fs_info->super_copy, - total_bytes + 1); + tmp + 1);
/* add sysfs device entry */ btrfs_kobj_add_device(root->fs_info, device);