On Sat, Mar 30, 2024 at 10:33:53AM +0100, Karel Balej wrote:
Sasha,
Sasha Levin, 2024-03-29T08:37:49-04:00:
From: Karel Balej balejk@matfyz.cz
[ Upstream commit 90cb57a6c5717b83a110c0da720a03ee32ed255e ]
IST3032C is a touchscreen chip used for instance in the samsung,coreprimevelte smartphone, with which this was tested. Add the chip specific information to the driver.
Reviewed-by: Markuss Broks markuss.broks@gmail.com Signed-off-by: Karel Balej balejk@matfyz.cz Link: https://lore.kernel.org/r/20240301164659.13240-6-karelb@gimli.ms.mff.cuni.cz Signed-off-by: Dmitry Torokhov dmitry.torokhov@gmail.com Signed-off-by: Sasha Levin sashal@kernel.org
drivers/input/touchscreen/imagis.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/drivers/input/touchscreen/imagis.c b/drivers/input/touchscreen/imagis.c index 9af8a6332ae67..e1fafa561ee38 100644 --- a/drivers/input/touchscreen/imagis.c +++ b/drivers/input/touchscreen/imagis.c @@ -11,6 +11,8 @@ #include <linux/property.h> #include <linux/regulator/consumer.h>
+#define IST3032C_WHOAMI 0x32c
#define IST3038B_REG_STATUS 0x20 #define IST3038B_REG_CHIPID 0x30 #define IST3038B_WHOAMI 0x30380b @@ -363,6 +365,13 @@ static int imagis_resume(struct device *dev)
static DEFINE_SIMPLE_DEV_PM_OPS(imagis_pm_ops, imagis_suspend, imagis_resume);
+static const struct imagis_properties imagis_3032c_data = {
- .interrupt_msg_cmd = IST3038C_REG_INTR_MESSAGE,
- .touch_coord_cmd = IST3038C_REG_TOUCH_COORD,
- .whoami_cmd = IST3038C_REG_CHIPID,
- .whoami_val = IST3032C_WHOAMI,
+};
static const struct imagis_properties imagis_3038b_data = { .interrupt_msg_cmd = IST3038B_REG_STATUS, .touch_coord_cmd = IST3038B_REG_STATUS, @@ -380,6 +389,7 @@ static const struct imagis_properties imagis_3038c_data = {
#ifdef CONFIG_OF static const struct of_device_id imagis_of_match[] = {
- { .compatible = "imagis,ist3032c", .data = &imagis_3032c_data }, { .compatible = "imagis,ist3038b", .data = &imagis_3038b_data }, { .compatible = "imagis,ist3038c", .data = &imagis_3038c_data }, { },
-- 2.43.0
sorry if I'm missing something, but I don't see why this should be backported: it doesn't fix anything, it's just adding support for new hardware.
I can see that adding a device ID is permitted for -stable [1], but I thought it still has to bear some signs of a fix, such as maybe here [2].
It does not need to be a fix, it could just be plain device enablement.