On Thu, Sep 13, 2018 at 01:18:34PM +0530, Viresh Kumar wrote:
On 12 September 2018 at 19:25, Niklas Cassel niklas.cassel@linaro.org wrote:
On Wed, Sep 12, 2018 at 01:58:39PM +0530, Viresh Kumar wrote:
Hello,
Niklas Cassle recently reported some regressions with his Qcom cpufreq driver where he was getting some errors while creating the OPPs tables.
After looking into it I realized that the OPP core incorrectly creates multiple OPP tables for the devices even if they are sharing the OPP table in DT. This happens when the request comes using different CPU devices. For example, dev_pm_opp_set_supported_hw() getting called using CPU0 and dev_pm_opp_of_add_table() getting called using CPU1.
This series redesigns the internals of the OPP core to fix that. The redesign has simplified the core itself though.
@Niklas: Can you please confirm that this series fixes the issues you have reported ? I have already tested it on Hikey960.
Hello Viresh,
This fixes the OPP error messages that I previously reported.
However, I also tested to add a duplicate OPP to the opp-table.
Before this series, I got the first two error prints. After this series, I get the first two error prints + the use after free splat.
This looks to be an old bug. Can you please try this branch:
Hello Viresh,
You confused me here, since you did hide the fix for this old bug in the middle of your new patch series :)
I think that it would have been more obvious to simply paste the fix/diff in your reply directly, since that is the most common way to post a potential fix. Or, if you are really confident in your fix, post a V2 directly.
However, your branch works like a charm, so feel free to add: Tested-by: Niklas Cassel niklas.cassel@linaro.org when sending out your branch as a V2.
Kind regards, Niklas
git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git opp/qcom-fix
?