On Thu, Apr 02, 2020 at 12:03:12PM -0700, James Smart wrote:
This patch partially reverts the commit for nvme_fc: add module to ops template to allow module references
The original patch: Added an ops parameter of "module" to be set by the lldd, and the lldds were updated to provide their value. Used the parameter to take module references when a controller was created or terminated.
The original patch was to resolve the lldd being able to be unloaded while being used to talk to the boot device of the system. However, the end result of the original patch is that any driver unload while a nvme controller is live via the lldd is not being prohibited. Given the module reference, the module teardown routine can't be called, thus there's no way, other than manual actions to terminate the controllers.
This patch reverts the portion of the patch that takes module references on controller creation. It leaves the module parameter so that it could be used in the future.
Please remove it entirely - we don't want to keep dead code around.