On Sun, Aug 13, 2023 at 05:45:09PM +0300, Sagi Grimberg wrote:
From: Ming Lei ming.lei@redhat.com
Move start_freeze into nvme_tcp_configure_io_queues(), and there is at least two benefits:
- fix unbalanced freeze and unfreeze, since re-connection work may
fail or be broken by removal
- IO during error recovery can be failfast quickly because nvme fabrics
unquiesces queues after teardown.
One side-effect is that !mpath request may timeout during connecting because of queue topo change, but that looks not one big deal:
same problem exists with current code base
compared with !mpath, mpath use case is dominant
Fixes: 2875b0aecabe ("nvme-tcp: fix controller reset hang during traffic") Cc: stable@vger.kernel.org Signed-off-by: Ming Lei ming.lei@redhat.com Tested-by: Yi Zhang yi.zhang@redhat.com Reviewed-by: Sagi Grimberg sagi@grimberg.me Signed-off-by: Keith Busch kbusch@kernel.org
drivers/nvme/host/tcp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
All now queued up, thanks.
greg k-h