On Mon, Aug 18, 2025 at 12:54:26PM +0900, Vincent Mailhol wrote:
Hi Sasha,
On Sun. 17 Aug. 2025 at 22:49, Sasha Levin sashal@kernel.org wrote:
This is a note to let you know that I've just added the patch titled
can: ti_hecc: fix -Woverflow compiler warningto the 6.15-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git%3Ba=su...
The filename of the patch is: can-ti_hecc-fix-woverflow-compiler-warning.patch and it can be found in the queue-6.15 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let stable@vger.kernel.org know about it.
This only silences a compiler warning. There are no actual bugs in the original code. This is why I did not put the Fixes tag.
I am not against this being backported to stable but please note that this depends on the new BIT_U32() macro which where recently added in commit 5b572e8a9f3d ("bits: introduce fixed-type BIT_U*()") Link: https://git.kernel.org/torvalds/c/5b572e8a9f3d
So, unless you also backport the above patch, this will not compile.
The options are:
drop this patch (i.e. keep that benin -Woverflow in stable)
backport the new BIT_U*() macros and keep the patch as-is
modify the patch as below:
mbx_mask = ~(u32)BIT(HECC_RX_LAST_MBOX);
I'll let you decide what you prefer. That comment also applies to the other backports of that patch except for the 6.16.x branch which already has the BIT_U*() macros.
Oops, missed this, it broke the build, as you point out, so I'll go drop it from all older kernels and revert it in 6.12.y now.
thanks,
greg k-h