On Tue, Jun 30, 2020 at 04:01:45PM +0200, Maximilian Heyne wrote:
On 6/30/20 3:36 PM, Christoph Hellwig wrote:
And actually - 1.0 did not have the concept of a subsystem. So having a duplicate serial number for a 1.0 controller actually is a pretty nasty bug. Can you point me to this broken controller? Do you think the OEM could fix it up to report a proper version number and controller ID?
I meant that the VF NVMe controllers will all land in the same subsystem from the kernel's point of view, because, as you said, there was no idea of different subsystems in the 1.0 spec.
Each controller should have landed in its own subsystem in this case rather than the same subsystem.
It's an older in-house controller. Seems to set the same serial number for all VF's. Should the firmware set unique serials for the VF's instead?
Yes, the driver shouldn't be finding duplicate serial numbers.