Re: [PATCH 1/2] cpufreq: armada-37xx: fix clock parenting

Hi Viresh,

On lun., mars 11 2019, Viresh Kumar viresh.kumar@linaro.org wrote:

On 08-03-19, 17:47, Gregory CLEMENT wrote:

[...]

...

parent = clk_get_parent(clk);

• /*

• * Unset parent clock to force the clock framework setting again
  

• * the clock parent
  

• */
  

• clk_set_parent(clk, NULL);
• /*

• * For the Armada 37xx CPU clocks, setting the parent will
  

• * actually configure the parent when DVFS is enabled. At
  

• * hardware level it will be a different register from the one
  

• * read when doing clk_get_parent that will be set with
  

• * clk_set_parent.
  

• */
  

  clk_set_parent(clk, parent);

}

Maybe this should be done right from the clock driver instead? As cpufreq may or maynot be enabled by default (Surely most of the people will always enable it, but I am just trying to find the right place for doing this). The way we are setting the clock parent isn't that great, and looks a bit hacky just because of the way clock framework is. Maybe doing it directly, without getting clock framework in between, from the clock driver may look sane ?

I've just sent a patch following your suggestion to the clock mailing but keeping you in CC too.

Gregory

-- viresh