On 8/5/20 12:45 PM, Linus Torvalds wrote:
On Wed, Aug 5, 2020 at 12:24 PM Guenter Roeck linux@roeck-us.net wrote:
On 8/5/20 11:37 AM, Linus Torvalds wrote:
Because the trivial fix would be something like the appended, which is the right thing to do anyway.
Correct.
I'll take that as an Ack, and also remove the crazy reverse include from archrandom.h that most definitely shouldn't be there.
Thanks, appreciated.
It's now commit 585524081ecd ("random: random.h should include archrandom.h, not the other way around") in my tree, because a grep for "archrandom.h" shows that now the only place it exists is <linux/random.h> and a few files that cannot possibly affect arm64 (because they are on x86 and powerpc, neither of which has that insane reverse include).
I tried to build arm64 on current mainline, after reverting the dts patches which cause the build failures there. Builds fine with both gcc 7.4.0 and 9.3.0. 5.7.14-rc2 builds as well with both old and new compilers. So hopefully we are fine.
Guenter