-----Original Message----- From: Vladimir Oltean vladimir.oltean@nxp.com Sent: 2024年9月27日 22:42 To: Wei Fang wei.fang@nxp.com Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; Claudiu Manoil claudiu.manoil@nxp.com; ast@kernel.org; daniel@iogearbox.net; hawk@kernel.org; john.fastabend@gmail.com; linux-kernel@vger.kernel.org; netdev@vger.kernel.org; bpf@vger.kernel.org; stable@vger.kernel.org; imx@lists.linux.dev Subject: Re: [PATCH net 2/3] net: enetc: fix the issues of XDP_REDIRECT feature
On Thu, Sep 19, 2024 at 04:41:03PM +0800, Wei Fang wrote:
@@ -2251,7 +2261,16 @@ static void enetc_disable_txbdr(struct enetc_hw
*hw, struct enetc_bdr *rx_ring)
enetc_txbdr_wr(hw, idx, ENETC_TBMR, 0); }
-static void enetc_disable_bdrs(struct enetc_ndev_priv *priv) +static void enetc_disable_rx_bdrs(struct enetc_ndev_priv *priv) +{
- struct enetc_hw *hw = &priv->si->hw;
- int i;
- for (i = 0; i < priv->num_rx_rings; i++)
enetc_disable_rxbdr(hw, priv->rx_ring[i]);+}
+static void enetc_disable_tx_bdrs(struct enetc_ndev_priv *priv) { struct enetc_hw *hw = &priv->si->hw; int i; @@ -2259,8 +2278,6 @@ static void enetc_disable_bdrs(struct
enetc_ndev_priv *priv)
for (i = 0; i < priv->num_tx_rings; i++) enetc_disable_txbdr(hw, priv->tx_ring[i]);
Please do not leave a blank line here. In the git tree after applying this patch, that blank line appears at the end of enetc_disable_tx_bdrs().
Thanks for reminder, it's weird that the checkpatch.pl did not raise a warning here.