Re: [PATCH V2] blk-mq: avoid sysfs buffer overflow by too many CPU cores

On Fri, Aug 16, 2019 at 10:54:17AM +0800, Ming Lei wrote:

It is reported that sysfs buffer overflow can be triggered in case of too many CPU cores(>841 on 4K PAGE_SIZE) when showing CPUs in blk_mq_hw_sysfs_cpus_show().

So use cpumap_print_to_pagebuf() to print the info and fix the potential buffer overflow issue.

Cc: stable@vger.kernel.org Cc: Mark Ray mark.ray@hpe.com Cc: Greg KH gregkh@linuxfoundation.org Fixes: 676141e48af7("blk-mq: don't dump CPU -> hw queue map on driver load") Signed-off-by: Ming Lei ming.lei@redhat.com

---

block/blk-mq-sysfs.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-)

No list of what changed from v1 under here?

Anyway, no, just delete the attribute please.

thanks,

greg k-h