From: Yuzuru10 yuzuru_10@proton.me
[ Upstream commit 7186b81807b4a08f8bf834b6bdc72d6ed8ba1587 ]
This patch adds DMI-based quirk for the Acer Nitro ANV15-41, allowing the internal microphone to be detected correctly on machines with "RB" as board vendor.
Signed-off-by: Yuzuru yuzuru_10@proton.me Link: https://patch.msgid.link/20250622225754.20856-1-yuzuru_10@proton.me Signed-off-by: Mark Brown broonie@kernel.org Signed-off-by: Sasha Levin sashal@kernel.org ---
**YES**
This commit should be backported to stable kernel trees. Here's my extensive analysis:
## Key Points Supporting Backporting:
1. **Device ID Addition**: According to the stable kernel rules in Documentation/process/stable-kernel-rules.rst:15, patches that "add a device ID" are explicitly acceptable for stable backporting. This commit adds a DMI quirk entry which is functionally equivalent to adding a device ID.
2. **Hardware Enablement Fix**: The commit fixes a real hardware issue - the internal microphone on the Acer Nitro ANV15-41 laptop doesn't work without this quirk. This is a concrete bug that affects real users.
3. **Minimal and Safe Change**: The patch adds only 7 lines to the `yc_acp_quirk_table[]` array: ```c + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "RB"), + DMI_MATCH(DMI_PRODUCT_NAME, "Nitro ANV15-41"), + } + }, ```
4. **Follows Established Pattern**: The change follows the exact same pattern as numerous other entries in the DMI quirk table. It's a simple addition to an existing table with no algorithmic changes or risk of regression.
5. **Precedent from Similar Commits**: Looking at the historical commits with similar characteristics: - commit 610010737f74 ("ASoC: amd: yc: Add DMI quirk for Lenovo Ideapad Pro 5 16ARP8") - Backported with Cc: stable - commit c6dce23ec993 ("ASoC: amd: yc: Add DMI quirk for MSI Bravo 15 C7VF") - Backported with Cc: stable - Multiple other similar commits were backported to stable
6. **No Risk of Regression**: The DMI matching is specific to the exact board vendor "RB" and product name "Nitro ANV15-41". This cannot affect any other hardware models.
## Analysis of the Code:
The change is in `sound/soc/amd/yc/acp6x-mach.c`, which is the machine driver for AMD Yellow Carp platform using DMIC (Digital Microphone). The `yc_acp_quirk_table[]` is a DMI (Desktop Management Interface) matching table that identifies specific laptop models that need special handling to enable their internal microphones.
Without this quirk, the AMD audio driver doesn't properly detect or initialize the internal microphone on the affected laptop model, leaving users without functioning audio input.
## Conclusion:
This is a textbook example of a commit suitable for stable backporting - it's a hardware enablement fix that adds a device-specific quirk with zero risk to other systems. The absence of an explicit "Cc: stable@vger.kernel.org" tag in the commit message doesn't disqualify it from backporting; it simply means the author didn't explicitly request it at submission time.
sound/soc/amd/yc/acp6x-mach.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c index d5dc1d48fca94..5be4e620eeba1 100644 --- a/sound/soc/amd/yc/acp6x-mach.c +++ b/sound/soc/amd/yc/acp6x-mach.c @@ -339,6 +339,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "83Q3"), } }, + { + .driver_data = &acp6x_card, + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "RB"), + DMI_MATCH(DMI_PRODUCT_NAME, "Nitro ANV15-41"), + } + }, { .driver_data = &acp6x_card, .matches = {