Re: [PATCH 1/2] phy: qcom-qmp-combo: fix init-count imbalance

On Tue, 2 May 2023 at 13:39, Johan Hovold johan+linaro@kernel.org wrote:

The init counter is not decremented on initialisation errors, which prevents retrying initialisation and can lead to the runtime suspend callback attempting to disable resources that have never been enabled.

Add the missing decrement on initialisation errors so that the counter reflects the state of the device.

Fixes: e78f3d15e115 ("phy: qcom-qmp: new qmp phy driver for qcom-chipsets") Cc: stable@vger.kernel.org # 4.12 Signed-off-by: Johan Hovold johan+linaro@kernel.org

---

drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org