RE: [PATCH] tpm,tpm_tis: Avoid warning splat at shutdown

From: Lino Sanfilippo l.sanfilippo@kunbus.com Sent: Thursday, February 1, 2024 5:37 AM Subject: [PATCH] tpm,tpm_tis: Avoid warning splat at shutdown

If interrupts are not activated the work struct 'free_irq_work' is not initialized. This results in a warning splat at module shutdown.

Fix this by always initializing the work regardless of whether interrupts are activated or not.

That's using flush_work(), which just waits for one to complete. Is there any case where multiple work entries could be queued, and cancel_work_sync() would be necessary?

tpm_tis_probe_irq() has a loop calling tpm_tis_probe_irq_single() for 3 to 15. Could each of those could trigger an interrupt storm and call tpm_tis_revert_interrupts(), which calls schedule_work()?