On Tue, Sep 03, 2019 at 11:52:06AM -0300, Marcelo Ricardo Leitner wrote:
On Tue, Sep 03, 2019 at 02:58:16PM +0800, Baolin Wang wrote:
From: Hariprasad Kelam hariprasad.kelam@gmail.com
This patch removes NULL checks before calling kfree.
fixes below issues reported by coccicheck net/sctp/sm_make_chunk.c:2586:3-8: WARNING: NULL check before some freeing functions is not needed. net/sctp/sm_make_chunk.c:2652:3-8: WARNING: NULL check before some freeing functions is not needed. net/sctp/sm_make_chunk.c:2667:3-8: WARNING: NULL check before some freeing functions is not needed. net/sctp/sm_make_chunk.c:2684:3-8: WARNING: NULL check before some freeing functions is not needed.
Hi. This doesn't seem the kind of patch that should be backported to such old/stable releases. After all, it's just a cleanup.
I agree, this does not seem necessary _unless_ it is needed for a later real fix.
thanks,
greg k-h