Hi Joakim,
Please Cc the MTD maintainers, not only the list (get_maintainers.pl).
Joakim Tjernlund joakim.tjernlund@infinera.com wrote on Thu, 22 Oct 2020 17:45:06 +0200:
Commit "mtd: cfi_cmdset_0002: Add support for polling status register" added support for polling the status rather than using DQ polling. However, status register is used only when DQ polling is missing. Lets use status register when available as it is superior to DQ polling.
I will let vignesh comment about the content (looks fine by me) but you will need a Fixes tag here.
Signed-off-by: Joakim Tjernlund joakim.tjernlund@infinera.com Cc: stable@vger.kernel.org
drivers/mtd/chips/cfi_cmdset_0002.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c index a1f3e1031c3d..ee9b322e63bb 100644 --- a/drivers/mtd/chips/cfi_cmdset_0002.c +++ b/drivers/mtd/chips/cfi_cmdset_0002.c @@ -117,7 +117,7 @@ static struct mtd_chip_driver cfi_amdstd_chipdrv = { static int cfi_use_status_reg(struct cfi_private *cfi) { struct cfi_pri_amdstd *extp = cfi->cmdset_priv;
- u8 poll_mask = CFI_POLL_STATUS_REG | CFI_POLL_DQ;
- u8 poll_mask = CFI_POLL_STATUS_REG;
return extp->MinorVersion >= '5' && (extp->SoftwareFeatures & poll_mask) == CFI_POLL_STATUS_REG;
Thanks, Miquèl