On Tue, Dec 10, 2024 at 11:59:14PM +0000, Ziwei Xiao wrote:
Netpoll will explicitly pass the polling call with a budget of 0 to indicate it's clearing the Tx path only. For the gve_rx_poll and gve_xdp_poll, they were mistakenly taking the 0 budget as the indication to do all the work. Add check to avoid the rx path and xdp path being called when budget is 0. And also avoid napi_complete_done being called when budget is 0 for netpoll.
The original fix was merged here: https://lore.kernel.org/r/20231114004144.2022268-1-ziweixiao@google.com Resend it since the original one was not cleanly applied to 5.15 kernel.
commit 278a370c1766 ("gve: Fixes for napi_poll when budget is 0")
Fixes: f5cedc84a30d ("gve: Add transmit and receive support") Signed-off-by: Ziwei Xiao ziweixiao@google.com Reviewed-by: Praveen Kaligineedi pkaligineedi@google.com Signed-off-by: Praveen Kaligineedi pkaligineedi@google.com
Changes in v2:
- Add the original git commit id
In the future, please add it in a way that we can figure it out (see the hundreds of examples on the mailing list for how it is done.)
thanks,
greg k-h