On 2/26/2024 9:02 PM, Mario Limonciello wrote:
On 2/26/2024 09:28, Basavaraj Natikar wrote:
The AMD USB host controller (1022:43f7) does not enter PCI D3 by default when nothing is connected. This is due to the policy introduced by 'commit a611bf473d1f ("xhci-pci: Set runtime PM as default policy on all xHC 1.2 or later devices")', which only covers 1.2 or later devices.
Therefore, by default, allow RPM on the AMD USB controller [1022:43f7].
Fixes: 4baf12181509 ("xhci: Loosen RPM as default policy to cover for AMD xHC 1.1") Link: https://lore.kernel.org/all/12335218.O9o76ZdvQC@natalenko.name/ Cc: Mario Limonciello mario.limonciello@amd.com Cc: stable@vger.kernel.org Tested-by: Oleksandr Natalenko oleksandr@natalenko.name
Does Oleksandr's testing actually apply here? This is a totally different patch and system isn't it?
This patch is added in https://lore.kernel.org/all/12335218.O9o76ZdvQC@natalenko.name/
And he mentioned in link https://lore.kernel.org/all/12335218.O9o76ZdvQC@natalenko.name/ to add Tested-by
Thanks, -- Basavaraj
Signed-off-by: Basavaraj Natikar Basavaraj.Natikar@amd.com
Changes in v2: - Added Cc: stable@vger.kernel.org
drivers/usb/host/xhci-pci.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c index b534ca9752be..1eb7a41a75d7 100644 --- a/drivers/usb/host/xhci-pci.c +++ b/drivers/usb/host/xhci-pci.c @@ -473,6 +473,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci) /* xHC spec requires PCI devices to support D3hot and D3cold */ if (xhci->hci_version >= 0x120) xhci->quirks |= XHCI_DEFAULT_PM_RUNTIME_ALLOW; + else if (pdev->vendor == PCI_VENDOR_ID_AMD && pdev->device == 0x43f7) + xhci->quirks |= XHCI_DEFAULT_PM_RUNTIME_ALLOW; if (xhci->quirks & XHCI_RESET_ON_RESUME) xhci_dbg_trace(xhci, trace_xhci_dbg_quirks,