Re: [PATCH 2/5] mm, devm_memremap_pages: handle errors allocating final devres action

On Mon, May 21, 2018 at 03:35:24PM -0700, Dan Williams wrote:

The last step before devm_memremap_pages() returns success is to allocate a release action to tear the entire setup down. However, the result from devm_add_action() is not checked.

Checking the error also means that we need to handle the fact that the percpu_ref may not be killed by the time devm_memremap_pages_release() runs. Add a new state flag for this case.

Looks good (modulo any stable tag issues):

Reviewed-by: Christoph Hellwig hch@lst.de