2018-03-08 16:09 GMT+09:00 James Hogan jhogan@kernel.org:
On Wed, Mar 07, 2018 at 03:19:11PM -0800, Frank Rowand wrote:
On 03/07/18 12:25, James Hogan wrote:
On Wed, Mar 07, 2018 at 12:11:41PM -0800, Frank Rowand wrote:
On 03/07/18 06:06, James Hogan wrote:
Quite a lot of dts files have hyphens, but its only a problem on MIPS where such files can be built into the kernel. For example when CONFIG_DT_NETGEAR_CVG834G=y, or on BMIPS kernels when the dtbs target is used (in the latter case it admitedly shouldn't really build all the dtb.o files, but thats a separate issue).
I'll keep the paragraph about MIPS and the example configuration though, as I think its important information to reproduce the problem, and to justify why it wouldn't be appropriate to just rename the files (which was my first reaction).
Other than the part that says "its only a problem on MIPS". That is pedantically correct because no other architecture (that I am aware of, not that I searched) currently has a devicetree source file name with a hyphen in it, where that file is compiled into the kernel as an asm file. But it is potentially a problem on any architecture to it is misleading to label it as MIPS only.
Okay I'll reword to make it clearer and do a v2.
Thanks James
The code looks good. If you send v2, I can shortly apply it to the fixes branch.
If possible, I want to send a PR this weekend.