On Mon, 2023-07-03 at 19:55 +0000, Souradeep Chakrabarti wrote:
-----Original Message----- From: Alexander Lobakin aleksander.lobakin@intel.com Sent: Monday, July 3, 2023 10:18 PM To: souradeep chakrabarti schakrabarti@linux.microsoft.com Cc: KY Srinivasan kys@microsoft.com; Haiyang Zhang haiyangz@microsoft.com; wei.liu@kernel.org; Dexuan Cui decui@microsoft.com; davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; Long Li longli@microsoft.com; Ajay Sharma sharmaajay@microsoft.com; leon@kernel.org; cai.huoqing@linux.dev; ssengar@linux.microsoft.com; vkuznets@redhat.com; tglx@linutronix.de; linux-hyperv@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; linux-rdma@vger.kernel.org; stable@vger.kernel.org; Souradeep Chakrabarti schakrabarti@microsoft.com Subject: [EXTERNAL] Re: [PATCH V4 net] net: mana: Fix MANA VF unload when host is unresponsive
From: Souradeep Chakrabarti schakrabarti@linux.microsoft.com Date: Mon, 3 Jul 2023 01:49:31 -0700
From: Souradeep Chakrabarti schakrabarti@linux.microsoft.com
Please sync your Git name and Git mail account settings, so that your own patches won't have "From:" when sending. From what I see, you need to correct first letters of name and surname to capital in the Git email settings block.
Thank you for pointing, I will fix it.
When unloading the MANA driver, mana_dealloc_queues() waits for the MANA hardware to complete any inflight packets and set the pending send count to zero. But if the hardware has failed, mana_dealloc_queues() could wait forever.
Fix this by adding a timeout to the wait. Set the timeout to 120 seconds, which is a somewhat arbitrary value that is more than long enough for functional hardware to complete any sends.
Signed-off-by: Souradeep Chakrabarti schakrabarti@linux.microsoft.com
Where's "Fixes:" tagging the blamed commit?
This is present from the day zero of the mana driver code. It has not been introduced in the code by any commit.
Then the fixes tag should be:
Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)")
Cheers,
Paolo