Quoting Binbin Zhou (2025-01-07 17:41:43)
On Wed, Jan 8, 2025 at 5:25 AM Stephen Boyd sboyd@kernel.org wrote:
Quoting Binbin Zhou (2024-12-24 22:05:59)
diff --git a/drivers/clk/clk-loongson2.c b/drivers/clk/clk-loongson2.c index 6bf51d5a49a1..b1b2038acd0b 100644 --- a/drivers/clk/clk-loongson2.c +++ b/drivers/clk/clk-loongson2.c @@ -294,7 +294,7 @@ static int loongson2_clk_probe(struct platform_device *pdev) return -EINVAL;
for (p = data; p->name; p++)
clks_num++;
clks_num = max(clks_num, p->id + 1);NULL is a valid clk. Either fill the onecell data with -ENOENT error pointers, or stop using it and implement a custom version of of_clk_hw_onecell_get() that doesn't allow invalid clks to be requested from this provider.
Emm... Just in case, how about setting all items to ERR_PTR(-ENOENT) before assigning them. This is shown below:
while (--clk_num >= 0) clp->clk_data.hws[clk_num] = ERR_PTR(-ENOENT);
Or something like:
memset_p(&clk->clk_data.hws, ERR_PTR(-ENOENT), clk_num);