On 7/6/2023 06:28, Thorsten Leemhuis wrote:
On 05.07.23 18:07, Limonciello, Mario wrote:
[Public]
can we check below patch series which solves this issue by initializing HID only if is_any_sensor_enabled. https://lore.kernel.org/all/nycvar.YFH.7.76.2305231559000.29760@cbobk. fhfr.pm/
The original reporter won't be able to test it because they've upgraded their firmware and SFH is disabled in the new firmware.
But yeah it seems plausible this series could help. If it comes back up again we should point anyone affected to this series.
Thanks!
Hmmm. So this won't be fixed in 6.3.y. and 6.4.y then, as none of those patches afaics looks like they will be picked up by the stable team?
Hmmm. That doesn't completely feel right to me, unless we consider the problem Haochen Ton ran into an extremely unlikely bug (reminder: only a few of those that encounter a problem will report it). Do we? If not: is backporting that patch-set to 6.4.y an option once this was in mainline for a while without causing trouble?
So the problem that was found is the following set of circumstances: 1) System that doesn't have sensors connected to SFH 2) System that has SFH enabled in BIOS
As this is already fixed in BIOS update for affected laptop that disabled SFH and the vendor publishes the BIOS to LVFS, I think it's unlikely to crop back up on this model.
If anything it might crop up on a different model that meets what I said above. If that happens, I suggest we ask any potential future reporters to test that series.
We can always backport it to remaining stable channels if it comes back.
Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr If I did something stupid, please tell me, as explained on that page.