Hi, This patch is already on upstream. Unfortunately, previous backports of related commits caused some issues so just skipping this one isn't a good option.
For module parameters, while it's quite unrealistic for users to have more than one identical keyboard but with different firmware, this is possible and having a module option would prevent tuning only specific keyboard.
For the documentation, makes sense. Sorry, I should have done it together with the change, I'll fix it, thanks for pointing it out.
On Thu, 28 Mar 2024 at 12:40, Pavel Machek pavel@denx.de wrote:
Hi!
From: Mikhail Khvainitski me@khvoinitsky.org
[ Upstream commit 2814646f76f8518326964f12ff20aaee70ba154d ]
Previous attempt to autodetect well-behaving patched firmware introduced in commit 46a0a2c96f0f ("HID: lenovo: Detect quirk-free fw on cptkbd and stop applying workaround") has shown that there are false-positives on original firmware (on both 1st gen and 2nd gen keyboards) which causes the middle button click workaround to be mistakenly disabled.
This commit adds explicit parameter to sysfs to control this workaround.
Should this go to stable? We have stream of lenovo workarounds, maybe -stable should wait for upstream to solve this.
Plus it should really have documentation.
Oh and we normally solve this stuff with module parameters, so that it can be fixed during bootup.
Best regards, Pavel
Fixes: 46a0a2c96f0f ("HID: lenovo: Detect quirk-free fw on cptkbd and stop applying workaround") Fixes: 43527a0094c1 ("HID: lenovo: Restrict detection of patched firmware only to USB cptkbd") Signed-off-by: Mikhail Khvainitski me@khvoinitsky.org Signed-off-by: Jiri Kosina jkosina@suse.com Signed-off-by: Sasha Levin sashal@kernel.org
-- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany