Re: [PATCH 4.19] IB/umem: fix reference count leak in ib_umem_odp_get()

On Fri, Jun 19, 2020 at 04:03:07PM +0000, Yang Yingliang wrote:

Add missing mmput() on error path to avoid ref-count leak.

This problem has already been resolved in mainline by f27a0d50a4bc ("RDMA/umem: Use umem->owning_mm inside ODP").

Fixes: 79bb5b7ee177 ("RDMA/umem: Fix missing mmap_sem in get umem ODP call") Signed-off-by: Yang Yingliang yangyingliang@huawei.com

---

drivers/infiniband/core/umem_odp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

We need an ack by the owner/maintainer of this code, please get the IB developers/maintainers to do that first.

Any reason why you didn't cc: them also?

thanks,

greg k-h