On Fri, Jun 06, 2025 at 10:20:56AM -0400, Yury Norov wrote:
On Fri, Jun 06, 2025 at 10:23:57AM +0200, Thomas Weißschuh wrote:
Commit 1e7933a575ed ("uapi: Revert "bitops: avoid integer overflow in GENMASK(_ULL)"") did not take in account that the usage of BITS_PER_LONG in __GENMASK() was changed to __BITS_PER_LONG for UAPI-safety in commit 3c7a8e190bc5 ("uapi: introduce uapi-friendly macros for GENMASK"). BITS_PER_LONG can not be used in UAPI headers as it derives from the kernel configuration and not from the current compiler invocation. When building compat userspace code or a compat vDSO its value will be incorrect.
Switch back to __BITS_PER_LONG.
Fixes: 1e7933a575ed ("uapi: Revert "bitops: avoid integer overflow in GENMASK(_ULL)"") Cc: stable@vger.kernel.org Signed-off-by: Thomas Weißschuh thomas.weissschuh@linutronix.de
Thanks Thomas. I applied it in bitmap-for-next. Is that issue critical enough for you to send a pull request in -rc2?
I have some patches that depend on it. These will probably end up in linux-next soonish and would then break there.
So having it in -rc2 would be nice.
Thanks