Re: [PATCH 5.10 011/575] scsi: core: Remove command size deduction from scsi_setup_scsi_cmnd()

On 11/15/21 09:58, Bart Van Assche wrote:

Hi Greg,

Thanks for having queued this patch for the 5.10 stable branch.

Do you plan to also include commit 20aaef52eb08 ("scsi: scsi_ioctl: Validate command size")? That patch prevents that the bug in the commit mentioned above can be triggered.

Thanks,

Hi Brad, The "scsi_ioctl: Validate command size" patch is not needed for either 5.10 nor 5.14 as the it is set directly from COMMAND_SIZE(opcode). See:

https://elixir.bootlin.com/linux/v5.14.18/source/block/scsi_ioctl.c#L445 https://elixir.bootlin.com/linux/v5.10.79/source/block/scsi_ioctl.c#L447