From: Yasmin Fitzgerald sunoflife1.git@gmail.com
[ Upstream commit 68cc9d3c8e44afe90e43cbbd2960da15c2f31e23 ]
The HP Pavilion Laptop 15-eg100 has Realtek HDA codec ALC287. It needs the ALC287_FIXUP_HP_GPIO_LED quirk to enable the mute LED.
Signed-off-by: Yasmin Fitzgerald sunoflife1.git@gmail.com Link: https://patch.msgid.link/20250621053832.52950-1-sunoflife1.git@gmail.com Signed-off-by: Takashi Iwai tiwai@suse.de Signed-off-by: Sasha Levin sashal@kernel.org ---
**YES**
This commit should be backported to stable kernel trees for the following reasons:
1. **Hardware enablement fix**: The commit adds a single line to the `alc269_fixup_tbl[]` quirk table to enable mute LED functionality on the HP Pavilion Laptop 15-eg100: ```c SND_PCI_QUIRK(0x103c, 0x898a, "HP Pavilion 15-eg100", ALC287_FIXUP_HP_GPIO_LED), ```
2. **Minimal and contained change**: This is a one-line addition that only affects the specific hardware identified by PCI subsystem ID (0x103c, 0x898a). There are no side effects on other systems.
3. **Uses established fixup**: The `ALC287_FIXUP_HP_GPIO_LED` fixup is already well-established in the kernel and used by other HP Pavilion models including: - HP Pavilion 15-eh1xxx (0x103c, 0x88d0) - HP Pavilion Aero Laptop 13-be0xxx (0x103c, 0x8919) - HP Pavilion 14-ec1xxx (0x103c, 0x8a0f)
4. **Fixes user-visible functionality**: Without this quirk, users of the HP Pavilion Laptop 15-eg100 would have a non-functional mute LED, which is an important visual feedback mechanism for audio state.
5. **Consistent with stable backport precedent**: All five similar historical commits that enabled mute LED functionality for HP laptops were backported to stable: - "Enable Mute LED on HP Laptop 14s-fq1xxx" (YES) - "Enable Mute LED on HP Laptop 14-fq0xxx" (YES) - "fix mute led of the HP Pavilion 15-eh1xxx series" (YES) - notably uses the same ALC287_FIXUP_HP_GPIO_LED - "Enable Mute LED on HP Laptop 15s-eq2xxx" (YES) - "Enable Mute LED on HP 255 G8" (YES)
6. **No risk of regression**: The change only applies to a specific hardware configuration and cannot affect other systems. The fixup mechanism is mature and the specific fixup being applied is already proven on other HP models.
This is a textbook example of a hardware enablement quirk that should be backported to stable kernels to ensure users of the HP Pavilion Laptop 15-eg100 have properly functioning hardware across all supported kernel versions.
sound/pci/hda/patch_realtek.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 3cacdbcb0d3ea..3f3a89ea2c2ee 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -9995,6 +9995,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x8975, "HP EliteBook x360 840 Aero G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x897d, "HP mt440 Mobile Thin Client U74", ALC236_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x8981, "HP Elite Dragonfly G3", ALC245_FIXUP_CS35L41_SPI_4), + SND_PCI_QUIRK(0x103c, 0x898a, "HP Pavilion 15-eg100", ALC287_FIXUP_HP_GPIO_LED), SND_PCI_QUIRK(0x103c, 0x898e, "HP EliteBook 835 G9", ALC287_FIXUP_CS35L41_I2C_2), SND_PCI_QUIRK(0x103c, 0x898f, "HP EliteBook 835 G9", ALC287_FIXUP_CS35L41_I2C_2), SND_PCI_QUIRK(0x103c, 0x8991, "HP EliteBook 845 G9", ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED),