Re: [PATCH 7/7] clone3: ensure copy_thread_tls is implemented

On Thu, Jan 2, 2020 at 7:09 PM Christian Brauner christian.brauner@ubuntu.com wrote:

I'm in favor of this change. But we need to make sure that any arch which now has ARCH_WANTS_SYS_CLONE3 set but doesn't implement copy_thread_tls() is fixed.

Once all architectures have clone3() support - and there are just a few by now (IA64 comes to mind) this means we should also be able to get rid of of copy_thread() completely. That seems desirable to me as it makes the codepaths easier to follow.

I've already implemented copy_thread_tls for all arches that currently have ARCH_WANTS_SYS_CLONE3 in the previous 5 patches. The #error is there so that any future arches that wire up clone3 don't forget to implement copy_thread_tls as well.