Re: [PATCH] HID: appletb-kbd: fix "appletb_backlight" backlight device reference counting

On Sun, 15 Jun 2025, Qasim Ijaz wrote:

During appletb_kbd_probe, probe attempts to get the backlight device by name. When this happens backlight_device_get_by_name looks for a device in the backlight class which has name "appletb_backlight" and upon finding a match it increments the reference count for the device and returns it to the caller. However this reference is never released leading to a reference leak.

Fix this by decrementing the backlight device reference count on removal via put_device and on probe failure.

Fixes: 93a0fc489481 ("HID: hid-appletb-kbd: add support for automatic brightness control while using the touchbar") Cc: stable@vger.kernel.org Signed-off-by: Qasim Ijaz qasdev00@gmail.com

Applied, thanks.