Re: [PATCH net v1 2/2] net: phy: dp83tg720: get initial master/slave configuration

On Thu, Jun 13, 2024 at 08:30:34PM +0200, Oleksij Rempel wrote:

Get initial master/slave configuration, otherwise ethtool wont be able to provide this information until link is established. This makes troubleshooting harder, since wrong role configuration would prevent the link start.

I looked at how genphy_c45_read_status() works. If we have phydev->autoneg == AUTONEG_ENABLE then genphy_c45_baset1_read_status() is called which sets phydev->master_slave_get. If not AUTONEG_ENABLE it calls genphy_c45_read_pma() which ends up calling genphy_c45_pma_baset1_read_master_slave().

So it seems like the .read_status op should be setting master/slave each time it is called, and not one time during .config_init.

What do you think?

Andrew