3.16.79-rc1 review patch. If anyone has any objections, please let me know.
------------------
From: Douglas Anderson dianders@chromium.org
commit 4faba50edbcc1df467f8f308893edc3fdd95536e upstream.
=46romcode inspection it can be seen that of_get_display_timing() is lacking an of_node_put(). Add it.
Fixes: ffa3fd21de8a ("videomode: implement public of_get_display_timing()") Signed-off-by: Douglas Anderson dianders@chromium.org Reviewed-by: Sam Ravnborg sam@ravnborg.org Cc: Thierry Reding thierry.reding@gmail.com Cc: David Airlie airlied@linux.ie Cc: Philipp Zabel p.zabel@pengutronix.de Cc: Tomi Valkeinen tomi.valkeinen@ti.com Cc: Laurent Pinchart laurent.pinchart@ideasonboard.com Cc: Russell King linux@armlinux.org.uk Cc: Daniel Vetter daniel@ffwll.ch Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnierkie@samsung.com Link: https://patchwork.freedesktop.org/patch/msgid/20190722182439.44844-2-diander... Signed-off-by: Ben Hutchings ben@decadent.org.uk --- drivers/video/of_display_timing.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
--- a/drivers/video/of_display_timing.c +++ b/drivers/video/of_display_timing.c @@ -114,6 +114,7 @@ int of_get_display_timing(struct device_ struct display_timing *dt) { struct device_node *timing_np; + int ret;
if (!np) return -EINVAL; @@ -125,7 +126,11 @@ int of_get_display_timing(struct device_ return -ENOENT; }
- return of_parse_display_timing(timing_np, dt); + ret = of_parse_display_timing(timing_np, dt); + + of_node_put(timing_np); + + return ret; } EXPORT_SYMBOL_GPL(of_get_display_timing);