Re: [PATCH] drm/panfrost: Use kvfree() to free bo->sgts in panfrost_mmu_map_fault_addr()

On 05/06/2020 19:52, Denis Efremov wrote:

Use kvfree() to free bo->sgts, because the memory is allocated with kvmalloc_array().

Fixes: 187d2929206e ("drm/panfrost: Add support for GPU heap allocations") Cc: stable@vger.kernel.org Signed-off-by: Denis Efremov efremov@linux.com

Well spotted, but there's another one in panfrost_gem_free_object(). Please can you fix that at the same time?

Thanks,

Steve

---

drivers/gpu/drm/panfrost/panfrost_mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panfrost/panfrost_mmu.c index ed28aeba6d59..3c8ae7411c80 100644 --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c @@ -486,7 +486,7 @@ static int panfrost_mmu_map_fault_addr(struct panfrost_device *pfdev, int as, pages = kvmalloc_array(bo->base.base.size >> PAGE_SHIFT, sizeof(struct page *), GFP_KERNEL | __GFP_ZERO); if (!pages) {

• 	kfree(bo->sgts);
  

• 	kvfree(bo->sgts);
  bo->sgts = NULL;
  mutex_unlock(&bo->base.pages_lock);
  ret = -ENOMEM;