On Mon, Jan 21, 2019 at 03:27:09PM +0100, Niklas Cassel wrote:
From: Marc Zyngier marc.zyngier@arm.com
The write to the status register is really an ACK for the HW, and should be treated as such by the driver. Let's move it to the irq_ack() callback, which will prevent people from moving it around in order to paper over other bugs.
Fixes: 8c934095fa2f ("PCI: dwc: Clear MSI interrupt status after it is handled, not before") Fixes: 7c5925afbc58 ("PCI: dwc: Move MSI IRQs allocation to IRQ domains hierarchical API") Link: https://lore.kernel.org/linux-pci/20181113225734.8026-1-marc.zyngier@arm.com... Reported-by: Trent Piepho tpiepho@impinj.com Tested-by: Niklas Cassel niklas.cassel@linaro.org Tested-by: Gustavo Pimentel gustavo.pimentel@synopsys.com Tested-by: Stanimir Varbanov svarbanov@mm-sol.com Signed-off-by: Marc Zyngier marc.zyngier@arm.com [lorenzo.pieralisi@arm.com: updated commit log] Signed-off-by: Lorenzo Pieralisi lorenzo.pieralisi@arm.com Cc: stable@vger.kernel.org
Original upstream commit SHA1: 3f7bb2ec20ce07c02b2002349d256c91a463fcc5
Sending a backport (which is authored by Marc, just like the original commit), for 4.14-stable, since the original commit failed to apply there.
Not sure if Tested-by tags should remain. Mine can be kept, since I've tested the backport.
drivers/pci/dwc/pcie-designware-host.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)
Now queued up, thanks.
greg k-h