Re: Please apply commit 3c047057d120 ("asm-generic: default BUG_ON(x) to if(x)BUG()") to v4.4.y

On Tue, Aug 20, 2019 at 11:36:25AM -0700, Guenter Roeck wrote:

Please apply commit 3c047057d120 ("asm-generic: default BUG_ON(x) to if(x)BUG()") to linux-4.4.y.

The commit is somewhat related to commit 173a3efd3edb ("bug.h: work around GCC PR82365 in BUG()") which has already been applied to v4.4.y. That patch assumes that commit 3c047057d120 is applied as well.

Commit 3c047057d120 avoids warnings such as

arch/x86/kernel/irqinit.c:157:2: warning: if statement has empty body [-Wempty-body]

which are reported randomly by 0day build reports. Besides, as Arnd points out in the commit, it avoids random behavior with CONFIG_BUG=n.

Now queued up, thanks!

greg k-h