4.14-stable review patch. If anyone has any objections, please let me know.
------------------
[ Upstream commit 47b998653fea4ef69e3e89574956386f262bccca ]
Commit 92571a1aae40 ("lan78xx: Connect phy early") moves the PHY initialisation into lan78xx_probe, but lan78xx_open subsequently calls lan78xx_reset. As well as forcing a second round of link negotiation, this reset frequently prevents the phy interrupt from being generated (even though the link is up), rendering the interface unusable.
Fix this issue by removing the lan78xx_reset call from lan78xx_open.
Fixes: 92571a1aae40 ("lan78xx: Connect phy early") Signed-off-by: Phil Elwell phil@raspberrypi.org Signed-off-by: David S. Miller davem@davemloft.net Signed-off-by: Sasha Levin sashal@kernel.org --- drivers/net/usb/lan78xx.c | 4 ---- 1 file changed, 4 deletions(-)
--- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -2508,10 +2508,6 @@ static int lan78xx_open(struct net_devic if (ret < 0) goto out;
- ret = lan78xx_reset(dev); - if (ret < 0) - goto done; - phy_start(net->phydev);
netif_dbg(dev, ifup, dev->net, "phy initialised successfully");