20 Aug
2024
20 Aug
'24
9:53 p.m.
On 8/19/24 4:19 PM, Damien Le Moal wrote:
On 8/20/24 01:59, Bart Van Assche wrote:
On 8/19/24 2:09 AM, Yihang Li wrote:
if ((sshdr.asc == 0x04 && sshdr.ascq == 0x04) ||Shouldn't symbolic names be introduced for these numeric constants? Although there is more code in the SCSI core that compares ASC / ASCQ values with numeric constants, I think we need symbolic names for these constants to make code like the above easier to read. There is already a header file for definitions that come directly from the SCSI standard and that is used by both SCSI initiator and SCSI target code: <scsi/scsi_proto.h>.
That would be *a lot* to define...
I meant introducing symbolic names only for the numerical constants that occur in this patch. Anyway, I'm fine with a descriptive comment too.
Bart.