On Wed Dec 11 19, Dan Williams wrote:
On Wed, Dec 11, 2019 at 3:27 PM Jerry Snitselaar jsnitsel@redhat.com wrote:
On Wed Dec 11 19, Jerry Snitselaar wrote:
Instead of repeatedly calling tpm_chip_start/tpm_chip_stop when issuing commands to the tpm during initialization, just reserve the chip after wait_startup, and release it when we are ready to call tpm_chip_register.
Cc: Christian Bundy christianbundy@fraction.io Cc: Dan Williams dan.j.williams@intel.com Cc: Peter Huewe peterhuewe@gmx.de Cc: Jarkko Sakkinen jarkko.sakkinen@linux.intel.com Cc: Jason Gunthorpe jgg@ziepe.ca Cc: Stefan Berger stefanb@linux.vnet.ibm.com Cc: stable@vger.kernel.org Cc: linux-intergrity@vger.kernel.org
Typo on the list address, do you want me to resend Jarkko?
Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()") Signed-off-by: Jerry Snitselaar jsnitsel@redhat.com
I did some initial testing with both a 1.2 device and a 2.0 device here. Christian, can you verify that this still solves your timeouts problem you were seeing? Dan, can you try this on the internal system with the interrupt issues? I will see if I can get the t490s owner to run it as well.
Will do. I assume you'd also want to add 'Fixes: 5b359c7c4372 ("tpm_tis_core: Turn on the TPM before probing IRQ's")' if it works?
Yes. I'm not certain this deals with the interrupt issue though, so didn't want to stick it on there yet. I guess it should go on there anyways since it is replacing that code. I'll post a v2.