Hello,
On Tue, Apr 10, 2018 at 02:30:26PM +0000, Bart Van Assche wrote:
Switching to another model might be better but let's please do that with the right rationales. A good portion of this seems to be built on misunderstandings.
Which misunderstandings? I'm not aware of any misunderstandings at my side. Additionally, tests with two different block drivers (NVMeOF initiator and the SRP initiator driver) have shown that the current blk-mq timeout implementation with or without your two patches applied result in subtle and hard to debug crashes and/or memory corruption. That is not the case for the
I must have missed that part. Which tests were they?
patch at the start of this thread. The latest report of a crash I ran into myself and that is fixed by the patch at the start of this thread is available here: https://www.spinics.net/lists/linux-rdma/msg63240.html.
Please also keep in mind that if this patch would be accepted that that does not prevent this patch to be replaced with an RCU-based solution later on. If anyone comes up any time with a reliably working RCU-based solution I will be happy to accept a revert of this patch and I will help reviewing that RCU-based solution.
Oh, switching is fine but let's get in sync first. Who have the repro cases and what were tested?
Thanks.