On 04/05/2018 02:46 PM, Peter Ujfalusi wrote:
When looking up the clock we must use the client->dev as device since that is the one which is probed via DT.
Signed-off-by: Peter Ujfalusi peter.ujfalusi@ti.com Cc: stable@vger.kernel.org Fixes: 7e2e6c5758de9 ("mfd: twl-core: Do not create dummy pdata when booted with DT")
This is not correct, we should only apply it to v4.16 since things worked before that with the drivers/clk/ti/clk-3xxx.c and drivers/clk/ti/clk-3xxx-legacy.c
Switching device to look for the fck might fail in pre 4.16.
But if this is the case then we might want to rename the fck clock to the correct hfclk.
On top of this patch a DT patch for the affected boards will be needed after 4.16 to define the hfclk clock (or if we do not rename it, the fck).
I'll send a v2 on Monday, but would like to hear your opinion on renaming fck to hfclk from 4.16 onwards (and update the documentation as well). The DT lookup is broken anyways w/o a patch similar to this.