Hi Coly,
I love your patch! Yet something to improve:
[auto build test ERROR on block/for-next] [also build test ERROR on net/master net-next/master ipvs/master linus/master v5.8 next-20200814] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Coly-Li/net-introduce-helper-sendpa... base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next config: i386-randconfig-s002-20200816 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.2-168-g9554805c-dirty # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All errors (new ones prefixed by >>):
In file included from net/core/stream.c:18: include/linux/net.h: In function 'sendpage_ok':
include/linux/net.h:301:30: error: implicit declaration of function 'page_count'; did you mean 'file_count'? [-Werror=implicit-function-declaration]
301 | return (!PageSlab(page) && page_count(page) >= 1); | ^~~~~~~~~~ | file_count In file included from include/linux/mm.h:27, from include/linux/bvec.h:13, from include/linux/skbuff.h:17, from include/linux/tcp.h:17, from net/core/stream.c:20: include/linux/page_ref.h: At top level:
include/linux/page_ref.h:70:19: error: static declaration of 'page_count' follows non-static declaration
70 | static inline int page_count(struct page *page) | ^~~~~~~~~~ In file included from net/core/stream.c:18: include/linux/net.h:301:30: note: previous implicit declaration of 'page_count' was here 301 | return (!PageSlab(page) && page_count(page) >= 1); | ^~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from net/ipv6/ip6_fib.c:20: include/linux/net.h: In function 'sendpage_ok':
include/linux/net.h:301:30: error: implicit declaration of function 'page_count'; did you mean 'file_count'? [-Werror=implicit-function-declaration]
301 | return (!PageSlab(page) && page_count(page) >= 1); | ^~~~~~~~~~ | file_count In file included from include/linux/mm.h:27, from include/linux/bvec.h:13, from include/linux/skbuff.h:17, from include/linux/if_ether.h:19, from include/uapi/linux/ethtool.h:19, from include/linux/ethtool.h:18, from include/linux/netdevice.h:37, from net/ipv6/ip6_fib.c:22: include/linux/page_ref.h: At top level:
include/linux/page_ref.h:70:19: error: static declaration of 'page_count' follows non-static declaration
70 | static inline int page_count(struct page *page) | ^~~~~~~~~~ In file included from net/ipv6/ip6_fib.c:20: include/linux/net.h:301:30: note: previous implicit declaration of 'page_count' was here 301 | return (!PageSlab(page) && page_count(page) >= 1); | ^~~~~~~~~~ net/ipv6/ip6_fib.c: In function 'fib6_add': net/ipv6/ip6_fib.c:1373:25: warning: variable 'pn' set but not used [-Wunused-but-set-variable] 1373 | struct fib6_node *fn, *pn = NULL; | ^~ cc1: some warnings being treated as errors -- In file included from net/ipv6/udp.c:24: include/linux/net.h: In function 'sendpage_ok':
include/linux/net.h:301:30: error: implicit declaration of function 'page_count'; did you mean 'file_count'? [-Werror=implicit-function-declaration]
301 | return (!PageSlab(page) && page_count(page) >= 1); | ^~~~~~~~~~ | file_count In file included from include/linux/mm.h:27, from include/linux/bvec.h:13, from include/linux/skbuff.h:17, from include/linux/if_ether.h:19, from include/uapi/linux/ethtool.h:19, from include/linux/ethtool.h:18, from include/linux/netdevice.h:37, from net/ipv6/udp.c:26: include/linux/page_ref.h: At top level:
include/linux/page_ref.h:70:19: error: static declaration of 'page_count' follows non-static declaration
70 | static inline int page_count(struct page *page) | ^~~~~~~~~~ In file included from net/ipv6/udp.c:24: include/linux/net.h:301:30: note: previous implicit declaration of 'page_count' was here 301 | return (!PageSlab(page) && page_count(page) >= 1); | ^~~~~~~~~~ net/ipv6/udp.c:1029:30: warning: no previous prototype for 'udp_v6_early_demux' [-Wmissing-prototypes] 1029 | INDIRECT_CALLABLE_SCOPE void udp_v6_early_demux(struct sk_buff *skb) | ^~~~~~~~~~~~~~~~~~ net/ipv6/udp.c:1070:29: warning: no previous prototype for 'udpv6_rcv' [-Wmissing-prototypes] 1070 | INDIRECT_CALLABLE_SCOPE int udpv6_rcv(struct sk_buff *skb) | ^~~~~~~~~ cc1: some warnings being treated as errors
vim +301 include/linux/net.h
283 284 #define net_get_random_once(buf, nbytes) \ 285 get_random_once((buf), (nbytes)) 286 #define net_get_random_once_wait(buf, nbytes) \ 287 get_random_once_wait((buf), (nbytes)) 288 289 /* 290 * E.g. XFS meta- & log-data is in slab pages, or bcache meta 291 * data pages, or other high order pages allocated by 292 * __get_free_pages() without __GFP_COMP, which have a page_count 293 * of 0 and/or have PageSlab() set. We cannot use send_page for 294 * those, as that does get_page(); put_page(); and would cause 295 * either a VM_BUG directly, or __page_cache_release a page that 296 * would actually still be referenced by someone, leading to some 297 * obscure delayed Oops somewhere else. 298 */ 299 static inline bool sendpage_ok(struct page *page) 300 {
301 return (!PageSlab(page) && page_count(page) >= 1);
302 } 303
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org