On (24/12/20 08:03), Dmitry Baryshkov wrote:
On Fri, Dec 20, 2024 at 01:32:48PM +0900, Sergey Senozhatsky wrote:
On (24/12/19 15:12), Dmitry Baryshkov wrote:
On Thu, Dec 19, 2024 at 02:37:08PM +0900, Sergey Senozhatsky wrote:
This partially reverts commit that made hfi_session_destroy() the first step of vdec/venc close(). The reason being is a regression report when, supposedly, encode/decoder is closed with still active streaming (no ->stop_streaming() call before close()) and pending pkts, so isr_thread cannot find instance and fails to process those pending pkts. This was the idea behind the original patch - make it impossible to use instance under destruction, because this is racy, but apparently there are uses cases that depend on that unsafe pattern. Return to the old (unsafe) behaviour for the time being (until a better fix is found).
You are describing a regression. Could you please add corresponding Reported-by and Closes tags (for now you can post them in a reply to your patch, in future please include them in your commit message).
The regression report is internal, I don't have anything public. One of the teams found out that some of their tests started to fail.
Still you probably can have a Repored-by, unless it's anonymous report.
Sure.
Fixes: 45b1a1b348ec ("media: venus: sync with threaded IRQ during inst destruction") Cc: stable@vger.kernel.org Signed-off-by: Sergey Senozhatsky senozhatsky@chromium.org
This is v2, but there is no changelog. Please provide one.
The code is obviously the same, I only added Cc: stable and removed one extra character in commit id "45b1a1b348ec".
This is the changelog. It helps reviewers to understand that there were no code changes between versions.
Sure.