From: Philipp Zabel p.zabel@pengutronix.de
[ Upstream commit 4fb26fb83f0def3d39c14e268bcd4003aae8fade ]
Abort instead of returning a new reset control for a reset controller device that is going to have its module unloaded.
Reported-by: Uwe Kleine-König u.kleine-koenig@pengutronix.de Fixes: 61fc41317666 ("reset: Add reset controller API") Acked-by: Uwe Kleine-König u.kleine-koenig@pengutronix.de Link: https://lore.kernel.org/r/20210607082615.15160-1-p.zabel@pengutronix.de Signed-off-by: Philipp Zabel p.zabel@pengutronix.de Signed-off-by: Sasha Levin sashal@kernel.org --- drivers/reset/core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/reset/core.c b/drivers/reset/core.c index 76c0dc7f165d..688b4f6227fc 100644 --- a/drivers/reset/core.c +++ b/drivers/reset/core.c @@ -565,7 +565,10 @@ static struct reset_control *__reset_control_get_internal( if (!rstc) return ERR_PTR(-ENOMEM);
- try_module_get(rcdev->owner); + if (!try_module_get(rcdev->owner)) { + kfree(rstc); + return ERR_PTR(-ENODEV); + }
rstc->rcdev = rcdev; list_add(&rstc->list, &rcdev->reset_control_head);