[Public]
-----Original Message----- From: Lyude Paul lyude@redhat.com Sent: Tuesday, November 15, 2022 5:55 AM To: Lin, Wayne Wayne.Lin@amd.com; amd-gfx@lists.freedesktop.org Cc: Wentland, Harry Harry.Wentland@amd.com; stable@vger.kernel.org; Li, Sun peng (Leo) Sunpeng.Li@amd.com; Siqueira, Rodrigo Rodrigo.Siqueira@amd.com; Deucher, Alexander Alexander.Deucher@amd.com; Koenig, Christian Christian.Koenig@amd.com; Pan, Xinhui Xinhui.Pan@amd.com; David Airlie airlied@gmail.com; Daniel Vetter daniel@ffwll.ch; Kazlauskas, Nicholas Nicholas.Kazlauskas@amd.com; Pillai, Aurabindo Aurabindo.Pillai@amd.com; Li, Roman Roman.Li@amd.com; Zuo, Jerry Jerry.Zuo@amd.com; Wu, Hersen hersenxs.wu@amd.com; Thomas Zimmermann tzimmermann@suse.de; Mahfooz, Hamza Hamza.Mahfooz@amd.com; Hung, Alex Alex.Hung@amd.com; Francis, David David.Francis@amd.com; Mikita Lipski mikita.lipski@amd.com; Liu, Wenjing Wenjing.Liu@amd.com; open list:DRM DRIVERS <dri- devel@lists.freedesktop.org>; open list linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drm/amdgpu/mst: Stop ignoring error codes and deadlocking
On Wed, 2022-11-09 at 09:48 +0000, Lin, Wayne wrote:
}
- if (!drm_dp_mst_atomic_check(state) && !debugfs_overwrite) {
- ret = drm_dp_mst_atomic_check(state);
- if (ret == 0 && !debugfs_overwrite) {
set_dsc_configs_from_fairness_vars(params, vars, count, k);
return true;
return 0;- } else if (ret == -EDEADLK) {
return ret;I think we should return here whenever there is an error. Not just for EDEADLK case.
Are we sure about this one? I think we may actually want to make this so it returns on ret != -ENOSPC, since we want the function to continue if there's no space in the atomic state available so it can try recomputing things with compression enabled. On ret == 0 it should return early without doing compression, and on ret == -ENOSPC it should just continue the function from there
Oh, right.. Thanks for saving me from causing disaster : )
-- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat
-- Regards, Wayne